krasimir marked an inline comment as done. krasimir added inline comments.
================ Comment at: lib/Format/TokenAnnotator.cpp:1612 + Keywords.kw_final) || + isCpp11AttributeSpecifier(*Tok.Next)) return false; ---------------- rdwampler wrote: > I think the issue r373922 was fixing is only related to the `delete`. Can > this check be move further up where we explicitly check if the token is the > delete keyword? > Sorry, I didn't notice this comment until now. I can investigate whether all the other cases for non-delete methods are already covered, it would be interesting. + @MyDeveloperDay, who might have better insights into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69164/new/ https://reviews.llvm.org/D69164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits