jkorous added inline comments.

================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:70
+    };
+    if (const int RC = llvm::sys::ExecuteAndWait(ClangBinaryPath, 
PrintResourceDirArgs, {}, Redirects)) {
+      auto ErrorBuf = llvm::MemoryBuffer::getFile(ErrorFile.c_str());
----------------
I haven't looked into this in detail but it feels kind of wasteful to start a 
process just to get this value. Can't we just expose it in some of the clang 
libs we already link against?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69122/new/

https://reviews.llvm.org/D69122



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to