Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
I was not sure why this is not opaque in case of LLDB usage, but now it is
perfect, thanks!
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3079
+ ", \"is_sink\":" << OtherNode->isSink() <<
+ ", \"has_report\": " << nodeHasBugReport(OtherNode) << " }";
},
----------------
Missing space at the end `", \"is_sink\":"` -> `", \"is_sink\": "`, and also I
like the booleans dumped as true/false, but it was a total arbitrary decision.
================
Comment at: clang/test/Analysis/exploded-graph-rewriter/node_labels.dot:46
+// COLOR-SAME: <font color="cornflowerblue"><b>Sink Node</b></font>
+// GREY-SAME: <b>Sink Node</b>
+// CHECK-SAME: </td>
----------------
`GREY` typo.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69015/new/
https://reviews.llvm.org/D69015
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
