aaron.ballman added inline comments.
================
Comment at: clang/lib/Sema/SemaStmt.cpp:2759
SemaRef.Context.getLValueReferenceType(E->getType().withConst());
- SemaRef.Diag(VD->getBeginLoc(), diag::note_use_type_or_non_reference)
- << NonReferenceType << NewReferenceType << VD->getSourceRange();
+ SemaRef.Diag(VD->getTypeSpecEndLoc(), diag::note_use_type_or_non_reference)
+ << NonReferenceType << NewReferenceType << VD->getSourceRange()
----------------
I don't think the diagnostic should point to the end of the type specification
rather than the beginning. That puts the caret in a rather strange location for
the diagnostic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68913/new/
https://reviews.llvm.org/D68913
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
