efriedma added a comment.
Hmm, the ObjC changes were simpler than I expected. And you managed to avoid
making changes to overload sets.
The changes related to IsAddressOfOperand are a nice simplification.
Would it make sense to always use ClassifyName from the parser, instead of
using ActOnIdExpression?
================
Comment at: include/clang/Sema/Sema.h:1865
+ NC_DependentNonType,
+ NC_ContextIndependentExpr,
NC_NestedNameSpecifier,
----------------
This enum could probably use brief comments explaining what the different
results mean.
================
Comment at: lib/Sema/SemaDecl.cpp:1191
+ return NameClassification::ContextIndependentExpr(
+ BuildDeclarationNameExpr(SS, Result, ADL));
+}
----------------
This doesn't depend on the context... because we're going to throw away the
expression later anyway? I guess that makes sense.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68896/new/
https://reviews.llvm.org/D68896
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
