ABataev added inline comments.

================
Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74
+  IntegerType *getSizeTTy() {
+    switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) {
+    case 4u:
----------------
sdmitriev wrote:
> ABataev wrote:
> > Same question as before: maybe better to make the size of size_t type a 
> > parameter of a tool?
> As I remember you also had another suggestion - change size_t to intptr_t. 
> That will eliminate the need to an additional parameter for size type. Will 
> it be better?
In thi case we'll need to change the type in the libomptarget.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68746/new/

https://reviews.llvm.org/D68746



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to