MyDeveloperDay marked 2 inline comments as done.
MyDeveloperDay added inline comments.
================
Comment at: clang/tools/clang-format/ClangFormat.cpp:371
+ if (!Replaces.empty()) {
+ IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts =
+ new DiagnosticOptions();
----------------
klimek wrote:
> I'd pull this block out into a function.
me too I've already done that, plus I think I'm leaking the
TestDiagnosticPrinter so I've corrected that locally. I'll update the patch but
I'd like to do some general tidying too which is why I submitted {D68767}
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68554/new/
https://reviews.llvm.org/D68554
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
