rnk marked an inline comment as done.
rnk added inline comments.
================
Comment at: clang/test/CoverageMapping/debug-dir.cpp:14
+//
+// RELATIVE: @__llvm_coverage_mapping = {{.*"\\01[^/]*foobar.*debug-dir\.cpp}}
+
----------------
vsk wrote:
> Does the "[^/]" check work on Windows, or is something like "[^/\\]"
> necessary?
It is insufficient on Windows, but the full string looks like
`"\01\0Dfoobar\5Cdebug-dir.cpp`, so `[^/\\]` would match the `\0D`. If the
`\0D` is the same across all systems, I could match that and it would suffice.
As is, this will catch absolute paths on Unix only, which could be enough
coverage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68733/new/
https://reviews.llvm.org/D68733
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
