programmerjake requested changes to this revision. programmerjake added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/lib/Frontend/InitPreprocessor.cpp:589 + if (LangOpts.CPlusPlus) { + Builder.defineMacro("__GNUG__", Twine(GNUCMinor)); + Builder.defineMacro("__GXX_WEAK__"); ---------------- Pretty sure that should be `GNUCMajor` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits