jrtc27 marked an inline comment as done. jrtc27 added a comment. In D58531#1662466 <https://reviews.llvm.org/D58531#1662466>, @jdoerfert wrote:
> I like the patch and I think it is fine. > > Small nits: > Could we have a test for " we can detect dodgy pthread_create declarations" > and maybe `pthread[_attr]_t`? > There is an unresolved comment by @shrines. > @probinson: "it seems straightforward enough although clearly needs > clang-format-diff run over it." > > I'll accept this assuming the above points are easy to fix and given that no > one expressed concerns but only positive comments were made. I believe I have addressed everything, with the possible exception of: > Could we have a test for " we can detect dodgy pthread_create declarations" > and maybe `pthread[_attr]_t`? Is that not what I had already added to `clang/test/Sema/implicit-builtin-decl.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
