jasonliu added a comment.
Any reason we are testing library search path using libgcc.a? We could use any
dummy path there, and upload a dummy archive library for the testing purpose.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:112
+
+AIX::~AIX() {}
+
----------------
We are not doing anything with the destructor. Do we need to declare and define
it?
================
Comment at: clang/lib/Driver/ToolChains/AIX.h:1
+//===--- AIX.h - AIX ToolChain Implementations ----------*- C++ -*-===//
+//
----------------
The length of this line should match with line 7.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68340/new/
https://reviews.llvm.org/D68340
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
