yonghong-song added a comment.

> All these names are not added as builtin enum before compilation starts, 
> right?

Do you prefer to have builtin enum? If we do this, we will emit this enum all 
the time,
regardless of whether people uses this builtin or not. Are you worried about API
stability?

I think defining explicitly in libbpf/btf.h probably a better choice? 
Defining commonly used macros like __bpf__ or __BPF__
makes more sense. Hidden enum's seems really rare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67980/new/

https://reviews.llvm.org/D67980



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to