aprantl added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1426 + // If we are not generating inline line tables, set the debug location + // of the inlined code to be the call site. + DebugLoc IDL = ---------------- aprantl wrote: > This will probably cause some IR Verifier failures and very confusing debug > info when inlining dbg.value intrinsics. The correct thing to do here is > probably to assign line 0 to the inlined instructions and remove all debug > info intrinsics. Otherwise the inlined variables will show up in the parent > frame, which will screw up debugging. cf. getMergedLocation() for how to do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
