simon_tatham marked an inline comment as done.
simon_tatham added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7442
+  case ParsedAttr::AT_ClangBuiltinOverride:
+    handleClangBuiltinOverrideAttribute(S, D, AL);
+    break;
----------------
aaron.ballman wrote:
> You should be able to call 
> `handleSimpleAttribute<ClangBuiltinOverrideAttr>()` instead.
Oh, nearly forgot: apparently I can't, because that template expects the 
attribute to have a constructor that takes only an `ASTContext` and an 
`AttributeCommonInfo`. But the constructor for my attribute also takes an 
`IdentifierInfo` giving the builtin name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67159/new/

https://reviews.llvm.org/D67159



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to