hokein added a comment.
The heuristic of guessing a concrete type seems fragile, and may not work for
all cases. Instead of trying out test to guess the underlying type, I think we
could introduce a new highlighting kind (e.g. `entity.name.type.dependent`) for
this.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181
+ addToken(E->getMemberLoc(), E->getQualifier()
+ ? HighlightingKind::StaticField
+ : HighlightingKind::Field);
----------------
This could be member functions, a case is like
```
template<class T>
class Foo {
public:
void foo() {
this->foo();
}
};
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67901/new/
https://reviews.llvm.org/D67901
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
