sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM. Looks like a straightforward fix and support for `punpk(hi|lo)`
intrinsics.
================
Comment at: llvm/lib/IR/Function.cpp:1213
// If this is a forward reference, defer the check for later.
- return D.getArgumentNumber() >= ArgTys.size() ||
- !isa<VectorType>(ArgTys[D.getArgumentNumber()]) ||
+ if (D.getArgumentNumber() >= ArgTys.size())
+ return IsDeferredCheck || DeferCheck(Ty);
----------------
Nice find!
================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-pred-operations.ll:1
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
+
----------------
nit: You've added the file `sve-intrinsics-pred-operations.ll`. Is it worth
putting these in a separate directory and separate out the tests per intrinsic,
e.g. `test/CodeGen/AArch64/SVE/sve-intrinsics-punpkhi.ll`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67830/new/
https://reviews.llvm.org/D67830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
