ilya-biryukov added a comment.

In D67825#1676528 <https://reviews.llvm.org/D67825#1676528>, @kadircet wrote:

> LGTM, I know it is trivial, but some more unittests wouldn't hurt anyone :D


Yeah, good point, I'll add a few besides tests for `printQualifiedName`.

> Also could you update the summary to mention "doing string manipulations in 
> the presence of template arguments is hard?"

Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67825/new/

https://reviews.llvm.org/D67825



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to