EricWF added inline comments.
================ Comment at: clang/include/clang/AST/Type.h:4353 + RemoveReferenceType, + AddRValueType, + AddLValueType ---------------- This should say ref in the name. ================ Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1094 + return DeclSpec::TST_removeReferenceType; + default: + assert(false && "Not a reference type specifier"); ---------------- Don't use default switch cases. It suppresses non-covered switch warnings, which we want fire when a new enumerator is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
