----- Original Message ----- > From: "Ulrich Weigand" <ulrich.weig...@de.ibm.com> > To: "Hal Finkel" <hfin...@anl.gov> > Cc: cfe-commits@lists.llvm.org > Sent: Monday, February 15, 2016 9:06:42 AM > Subject: Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP > macros > > > > Hal Finkel <hfin...@anl.gov> wrote on 09.02.2016 18:16:21: > > > > I guess any application that uses C++11 threads should show this > > > problem immediately. > > > > I'm not sure we have anything like that in our test suite. Could > > you > > add a simple test? > > Hmm, it looks like Nemanja already added this: > > SingleSource/UnitTests/C++11/ stdthreadbug.cpp > > But the test is restricted to run only on ppc64le: > > #if defined(_LITTLE_ENDIAN) && defined(__PPC64__) > ... > > I think there's no particular reason for that restriction. > Do you think we should just enable it on all platforms?
Yes, certainly. Sometimes we need to blacklist some tests for some platforms, but only fundamentally-platform-specific tests should be white listed like this. -Hal > > Bye, > Ulrich > > -- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
