aprantl added inline comments.
================
Comment at: include/clang/AST/DeclCXX.h:2931
+ lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a,
+ lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021
};
----------------
I understand that DWARF does not define a C++17 language constant, but in the
AST I fell like we should represent it, even if it is being lowered into C++14
for the debug info.
================
Comment at: lib/AST/DeclPrinter.cpp:1009
+ l = "C++_14";
+ else if (D->getLanguage() == LinkageSpecDecl::lang_cxx_11)
+ l = "C++_11";
----------------
Can you turn this into a switch() statement?
================
Comment at: lib/AST/DeclPrinter.cpp:1010
+ else if (D->getLanguage() == LinkageSpecDecl::lang_cxx_11)
+ l = "C++_11";
+ else {
----------------
Why this weird spelling with the underscore?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67613/new/
https://reviews.llvm.org/D67613
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
