Author: xbolva00
Date: Sat Sep 14 12:38:55 2019
New Revision: 371924
URL: http://llvm.org/viewvc/llvm-project?rev=371924&view=rev
Log:
[Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/Sema/div-sizeof-array.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=371924&r1=371923&r2=371924&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Sat Sep 14 12:38:55 2019
@@ -9200,6 +9200,8 @@ static void DiagnoseDivisionSizeofPointe
S.Diag(LHSArgDecl->getLocation(), diag::note_array_declared_here)
<< LHSArgDecl;
}
+
+ S.Diag(Loc, diag::note_precedence_silence) << RHS;
}
}
Modified: cfe/trunk/test/Sema/div-sizeof-array.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/div-sizeof-array.cpp?rev=371924&r1=371923&r2=371924&view=diff
==============================================================================
--- cfe/trunk/test/Sema/div-sizeof-array.cpp (original)
+++ cfe/trunk/test/Sema/div-sizeof-array.cpp Sat Sep 14 12:38:55 2019
@@ -9,21 +9,38 @@ int f(Ty (&Array)[N]) {
typedef int int32;
void test(void) {
- int arr[12]; // expected-note 2 {{array 'arr' declared here}}
+ int arr[12]; // expected-note 2 {{array 'arr' declared here}}
unsigned long long arr2[4];
int *p = &arr[0];
int a1 = sizeof(arr) / sizeof(*arr);
int a2 = sizeof arr / sizeof p; // expected-warning {{expression does not
compute the number of elements in this array; element type is 'int', not 'int
*'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof p' expression to
silence this warning}}
int a4 = sizeof arr2 / sizeof p;
int a5 = sizeof(arr) / sizeof(short); // expected-warning {{expression does
not compute the number of elements in this array; element type is 'int', not
'short'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof(short)'
expression to silence this warning}}
int a6 = sizeof(arr) / sizeof(int32);
int a7 = sizeof(arr) / sizeof(int);
int a9 = sizeof(arr) / sizeof(unsigned int);
const char arr3[2] = "A";
int a10 = sizeof(arr3) / sizeof(char);
+ int a11 = sizeof(arr2) / (sizeof(unsigned));
+ int a12 = sizeof(arr) / (sizeof(short));
int arr4[10][12]; // expected-note 3 {{array 'arr4'
declared here}}
int b1 = sizeof(arr4) / sizeof(arr2[12]); // expected-warning {{expression
does not compute the number of elements in this array; element type is 'int
[12]', not 'unsigned long long'}}
- int b2 = sizeof(arr4) / sizeof(int *); // expected-warning {{expression
does not compute the number of elements in this array; element type is 'int
[12]', not 'int *'}}
- int b3 = sizeof(arr4) / sizeof(short *); // expected-warning {{expression
does not compute the number of elements in this array; element type is 'int
[12]', not 'short *'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof (arr2[12])'
expression to silence this warning}}
+ int b2 = sizeof(arr4) / sizeof(int *); // expected-warning {{expression does
not compute the number of elements in this array; element type is 'int [12]',
not 'int *'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof(int *)'
expression to silence this warning}}
+ int b3 = sizeof(arr4) / sizeof(short *); // expected-warning {{expression
does not compute the number of elements in this array; element type is 'int
[12]', not 'short *'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof(short *)'
expression to silence this warning}}
+
+ int arr5[][5] = { // expected-note 2 {{array 'arr5' declared here}}
+ {1, 2, 3, 4, 5},
+ {6, 7, 8, 9, 0},
+ };
+ int c1 = sizeof(arr5) / sizeof(*arr5);
+ int c2 = sizeof(arr5) / sizeof(**arr5); // expected-warning {{expression
does not compute the number of elements in this array; element type is 'int
[5]', not 'int'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof (**arr5)'
expression to silence this warning}}
+ int c3 = sizeof(arr5) / sizeof(int); // expected-warning {{expression does
not compute the number of elements in this array; element type is 'int [5]',
not 'int'}}
+ // expected-note@-1 {{place parentheses around the 'sizeof(int)' expression
to silence this warning}}
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
