NoQ marked 2 inline comments as done. NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp:302-303 // Find the node's current statement in the CFG. - if (const Stmt *S = PathDiagnosticLocation::getStmt(this)) + // FIXME: getStmtForDiagnostics() does nasty things in order to provide + // a valid statement for body farms, do we need this behavior here? + if (const Stmt *S = getStmtForDiagnostics()) ---------------- Szelethus wrote: > But still fails... Well, not everything is a statement. ================ Comment at: clang/lib/StaticAnalyzer/Core/PathDiagnostic.cpp:565-566 // FIXME: Ironically, this assert actually fails in some cases. //assert(L.isValid()); return L; ---------------- Szelethus wrote: > I guess didn't change much :^) Indeed :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67382/new/ https://reviews.llvm.org/D67382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
