hubert.reinterpretcast added inline comments.

================
Comment at: lib/Frontend/InitPreprocessor.cpp:718
@@ -717,1 +717,3 @@
+  if (TI.hasFloat128Type())
+    DefineFloatMacros(Builder, "FLT128", &TI.getFloat128Format(), "Q");
 
----------------
I am concerned that setting these macros are premature. We still do not know if 
the `_Float128` type from the C Technical Specification (which has claim to 
`FLT128_`*, although not necessarily the double-underscore versions) will be 
the same type as `__float128`. The latter may be considered typedef-equivalent 
to `long double`; the former shall not be.


Repository:
  rL LLVM

http://reviews.llvm.org/D15120



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to