ilya-biryukov added a comment. In D67277#1662669 <https://reviews.llvm.org/D67277#1662669>, @hokein wrote:
> LGTM, though I think the current implementation is a common pattern. Thanks. It's indeed a common pattern. The problem is that it forces clients to handle this extra case in every switch statement (otherwise we get compiler warnings). `LastKind` avoids this, therefore it's arguably a little better for the clients. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67277/new/ https://reviews.llvm.org/D67277 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
