Eugene.Zelenko added a comment.

In D64671#1661585 <https://reviews.llvm.org/D64671#1661585>, @jpakkane wrote:

> > It'll be reasonable to get IncludeStyle default from .clang-format.
>
> I looked at existing checks and they all do the same thing as this one. In 
> fact I got the code for this by directly copypasting an existing check.


SInse this option may be also set in .clang-format, it's reasonable to re-use 
it instead of forcing user to duplicate it.



================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:71
+
+- New :doc:`cppcoreguidelines-init-variables
+  <clang-tidy/checks/cppcoreguidelines-init-variables>` check.
----------------
jpakkane wrote:
> Eugene.Zelenko wrote:
> > Please sort new checks list alphabetically.
> The list is already incorrectly alphabetized. Should I reorganize all the 
> entries or just put mine in a "correct" spot (between "bugprone" and 
> "linuxkernel")?
It'll not hurt to correct other mistakes too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64671/new/

https://reviews.llvm.org/D64671



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to