rjmccall added inline comments.
Herald added a subscriber: ychen.
================
Comment at: lib/Sema/SemaDecl.cpp:11142
+bool ignoreForTrivialityComputation(const FieldDecl *FD) {
+ // Ignore unavailable fields since they don't affect the triviality of the
----------------
`shouldIgnoreForRecordTriviality` or something like that, please.
================
Comment at: lib/Sema/SemaDecl.cpp:11144
+ // Ignore unavailable fields since they don't affect the triviality of the
+ // containing struct/union.
+ return FD->hasAttr<UnavailableAttr>();
----------------
The "since" clause here is circular: this function *defines* what affects the
triviality. The comment should talk about the motivations (e.g. fields that
aren't available in particular language modes) and why this might be okay or is
the best-available option (despite e.g. the potential for ABI incompatibility
across language modes),
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65256/new/
https://reviews.llvm.org/D65256
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
