greened added inline comments.
================
Comment at: docs/LangRef.rst:3818
+- ``Upl``: One of the low eight SVE predicate registers (P0 to P7)
+- ``Upa``: Any of the SVE predicate registers (P0 to P15)
----------------
What do these names mean? "<something> predicate lower|all?" I see they are
the names used in gcc, so I guess it makes sense to use them here. Are these
names used in the SVE architecture manual somewhere? I cannot find them.
================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5747
+
+PredicateConstraint isPredicateConstraint(StringRef Constraint) {
+ PredicateConstraint P = PredicateConstraint::Invalid;
----------------
rovka wrote:
> Nit: I think get- or parsePredicateConstraint reads better, since this
> doesn't return a simple yes/no answer.
+1.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66524/new/
https://reviews.llvm.org/D66524
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
