xbolva00 marked an inline comment as done.
xbolva00 added inline comments.
================
Comment at: lib/Sema/SemaExpr.cpp:11031-11032
// Do not diagnose macros.
- if (Loc.isMacroID())
+ if (Loc.isMacroID() || XorLHS.get()->getBeginLoc().isMacroID() ||
+ XorRHS.get()->getBeginLoc().isMacroID())
return;
----------------
aaron.ballman wrote:
> I would appreciate it if this patch didn't also change the behavior for
> macros. That seems like a larger discussion that can happen in a separate
> patch.
+1, agree.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66397/new/
https://reviews.llvm.org/D66397
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
