efriedma added a comment.

Do we have test coverage for a variadic, covariant thunk for a function without 
a definition?  I don't think there's any way for us to actually emit that, but 
we should make sure the error message is right.

I'm a little concerned that using musttail thunks with the Itanium ABI will 
flush out bugs that have been hiding because we have less test coverage on 
Windows. But it's probably the right thing to do.



================
Comment at: clang/lib/CodeGen/CGVTables.cpp:206
+  AdjustedThisPtr = Builder.CreateBitCast(AdjustedThisPtr,
+                                          ThisStore->getOperand(0)->getType());
   ThisStore->setOperand(0, AdjustedThisPtr);
----------------
This is fine, I guess, but how is it related?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67028/new/

https://reviews.llvm.org/D67028



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to