NoQ marked an inline comment as done.
NoQ added inline comments.
================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:75
/// individual bug reports.
class BugReport : public llvm::ilist_node<BugReport> {
public:
----------------
NoQ wrote:
> gribozavr wrote:
> > Szelethus wrote:
> > > Shouldn't we make this an abstract class?
> > I'm not sure that intrusive linked list is the right data structure for the
> > job. I'd personally put bug reports into a vector and make a custom data
> > structure if a vector becomes a performance problem.
> > Shouldn't we make this an abstract class?
>
> Mmm, yeah, moved virtual methods from `BugReport` to `BasicBugReport`
> whenever `PathSensitiveBugReport` immediately overrides them and it looks
> much better now!
>
> > I'm not sure that intrusive linked list is the right data structure for the
> > job.
>
> Me neither, but it seems to be orthogonal to this patch, and this patch is
> already huge, so i'll do this in a follow-up patch, ok?
D67024
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66572/new/
https://reviews.llvm.org/D66572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
