aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a nit with `auto`. ================ Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:47 + for (const auto *UsingDirective : Context->using_directives()) { + const auto *Namespace = UsingDirective->getNominatedNamespace(); + if (isa<TranslationUnitDecl>(Namespace->getDeclContext()) && ---------------- Don't use `const auto *` here as the type is not spelled out in the initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65919/new/ https://reviews.llvm.org/D65919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits