NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks!!

In D66715#1644395 <https://reviews.llvm.org/D66715#1644395>, @Szelethus wrote:

> Mind that I'll probably commit without the unit test, last time I learned the 
> hard way that the AST's lifetime ends by the time we retrieve the CFG.


Ouch. We'll need to fix that eventually because the CFG is, by design, filled 
with AST pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66715/new/

https://reviews.llvm.org/D66715



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D66715: [CFG] Add ... Artem Dergachev via Phabricator via cfe-commits

Reply via email to