ilya-biryukov added a comment.
Overall LG, thanks! Not sure why we need to keep `IndexingOptions` everywhere,
though, see the relevant comment.
================
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217
std::unique_ptr<CanonicalIncludes> Includes;
+ index::IndexingOptions Opts;
std::unique_ptr<CommentHandler> PragmaHandler;
----------------
Are these option ever used? Do we need to keep them alive for the lifetime of
the action?
Might be worth a comment.
================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:227
+ std::shared_ptr<index::IndexDataConsumer> DataConsumer;
+ index::IndexingOptions Opts;
CommentHandler *PragmaHandler;
----------------
Same here, we do not seem to use `Opts`, but still store them. To keep them
alive?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66878/new/
https://reviews.llvm.org/D66878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
