sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888
+ // treat missing host triple as error if we do unbundling.
+ if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) {
Error = true;
----------------
ABataev wrote:
> I believe, for unbundling we also must check for `!= 1` rather than `> 1`.
> Zero host targets also is not allowed.
But the whole idea of this change is to remove requirement to provide host
triple for unbundling operation. Target bundle(s) can always be extracted
without extracting host, so host bundle is optional. Therefore zero host
targets should not be considered as error for unbundling.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66601/new/
https://reviews.llvm.org/D66601
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
