Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`bugprone-posix-return + <clang-tidy/checks/bugprone-posix-return>` check. ---------------- Check is not new, just modified. Such check should be after new checks. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:71 +- New :doc:`bugprone-posix-return + <clang-tidy/checks/bugprone-posix-return>` check. + This check now also checks if any calls to pthread_* functions expect ---------------- Please insert empty line below. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:72 + <clang-tidy/checks/bugprone-posix-return>` check. + This check now also checks if any calls to pthread_* functions expect + negative return values. ---------------- Please omit //This check//. Please enclose pthread_* in double back-ticks. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-posix-return.rst:6 -Checks if any calls to POSIX functions (except ``posix_openpt``) expect negative -return values. These functions return either ``0`` on success or an ``errno`` on failure, -which is positive only. +Checks if any calls to pthread_* or posix_* functions (except ``posix_openpt``) +expect negative return values. These functions return either ``0`` on success ---------------- Please enclose pthread_* and posix_* in double back-ticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
