jkorous marked 3 inline comments as done. jkorous added inline comments.
================ Comment at: clang/tools/libclang/Indexing.cpp:371 - SessionSkipBodyData *SKData; - std::unique_ptr<TUSkipBodyControl> SKCtrl; + SharedParsedRegionsStorage *SKData; + std::unique_ptr<ParsedSrcLocationsTracker> ParsedLocsTracker; ---------------- jkorous wrote: > gribozavr wrote: > > This pointer seems to be only used in the constructor, however the > > constructor already has access to `skData` parameter. > Are you saying that we don't need this member and can just create > `ParsedSrcLocationsTracker` in `CreateASTConsumer` since we have the `skData`? If yes, then it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66694/new/ https://reviews.llvm.org/D66694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
