hokein added inline comments.
================
Comment at:
clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94
+ vscode.window.onDidChangeVisibleTextEditors(
+ () => this.highlighter.onDidChangeVisibleTextEditors());
+ vscode.workspace.onDidCloseTextDocument(
----------------
I think we can do it like
`vscode.window.onDidChangeVisibleTextEditors((TextEditor[] editors) => { //
call applyHighlight for each text editor })`.
================
Comment at:
clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:176
+ // the text document that was closed.
+ public onDidCloseTextDocument(fileUri: string) {
+ // If there exists no entry the call to delete just returns false.
----------------
the name is a bit weird `onDidCloseTextDocument` in the `Highlighter`, I would
name it `removeFileHighlights`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66735/new/
https://reviews.llvm.org/D66735
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
