aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/cppcoreguidelines-init-variables.cpp:3 + +#include <stdint.h> + ---------------- Eugene.Zelenko wrote: > lebedev.ri wrote: > > Eugene.Zelenko wrote: > > > It'll be better to include cstdint. > > I'll correct that comment: tests normally shouldn't depend on system > > headers; can you just mock whatever you need from there? > If test is C++, why not to include C++ equivalent of system headers? See > modernize-deprecated-headers. Because we want our tests to be hermetic and rely on the system running the test as little as possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
