nickdesaulniers added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:8101
+ // All further checking is done on the subexpression
+ Match = AT.matchesType(S.Context, ExprTy);
+ if (Match) {
----------------
Maybe leave the top level Match const and just create a new one? It may be
surprising if someone goes to reuse `Match` below not noticing that it may be
modified here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66186/new/
https://reviews.llvm.org/D66186
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
