ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:467 + // Per LSP, codeActionProvide can be either boolean or CodeActionOptions. + // CodeActionOptions is only valid if the client supports action liveral ---------------- NIT: a typo, s/codeActionProvide/codeActionProvider ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:468 + // Per LSP, codeActionProvide can be either boolean or CodeActionOptions. + // CodeActionOptions is only valid if the client supports action liveral + // support (via textDocument.codeAction.codeActionLiteralSupport). ---------------- s/action liveral/action literal ================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:469 + // CodeActionOptions is only valid if the client supports action liveral + // support (via textDocument.codeAction.codeActionLiteralSupport). + llvm::json::Value CodeActionProvider = true; ---------------- NIT: remove 'support', remove parentheses? Otherwise we have clients **supports** action literal **support** Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66592/new/ https://reviews.llvm.org/D66592 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
