aaron.ballman added a comment. In D66397#1639696 <https://reviews.llvm.org/D66397#1639696>, @thakis wrote:
> In D66397#1635792 <https://reviews.llvm.org/D66397#1635792>, @aaron.ballman > wrote: > > > In D66397#1635745 <https://reviews.llvm.org/D66397#1635745>, @xbolva00 > > wrote: > > > > > I think it is too soon to jump and disable all macros. We still catch all > > > motivating cases, it found bugs in Chromium. > > > > > > I think it's too soon to disable any macros. The workaround for Chromium is > > trivial and makes the code more clear. > > > I think I missed the workaround. I only saw the suggestion to write 0x2 > instead of 2 which doesn't seem more clear at all to me. Was there another > fix suggestion? Nope, you didn't miss it -- that was the suggestion. Using a hex notation is the way we let programmers signify that they want to do bit fiddling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
