xbolva00 added a subscriber: hans. xbolva00 added a comment. >> I think it's too soon to disable any macros.
It is hard to say (this was discussed a lot). @tkanis or @hans what do you think? Maybe you could do experiments for us. Comment the code which disables this warning in macros and try it on Chromium - let’s see how many false positives/negatives it could produce. This could really resolve “macro” question. But please let’s not repeat same “macro yes/no” arguments from last review. Anyway, I could make -Wxor-used-as-pow-in-macro so everybody would be happy. Is it solution? Now, Chromium disabled this warning :( until we “fix” it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
