hokein added a comment.

In D66211#1629112 <https://reviews.llvm.org/D66211#1629112>, @ilya-biryukov 
wrote:

> How do they look in practice? In particular, should we add more context 
> information (either in clangd or in the VSCode extension) to those errors, 
> now that we know they are shown to the users?
>  Something like `Failed to apply a fix: input range is invalid` vs `input 
> range is invalid`.


I don't have a very strong preference on adding more context, the current 
messages seem good enough to me, something like:

- "edits were not applied: <reason>"
- "Could not expand type of lambda expression:"
- "Could not obtain range of the 'else' branch. Macros?"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66211/new/

https://reviews.llvm.org/D66211



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to