This revision was automatically updated to reflect the committed changes.
Closed by commit rL368832: Removed ToolExecutor::isSingleProcess, it is not
used by anything (authored by gribozavr, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D66212?vs=215080&id=215082#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66212/new/
https://reviews.llvm.org/D66212
Files:
cfe/trunk/include/clang/Tooling/AllTUsExecution.h
cfe/trunk/include/clang/Tooling/Execution.h
cfe/trunk/include/clang/Tooling/StandaloneExecution.h
cfe/trunk/unittests/Tooling/ExecutionTest.cpp
Index: cfe/trunk/unittests/Tooling/ExecutionTest.cpp
===================================================================
--- cfe/trunk/unittests/Tooling/ExecutionTest.cpp
+++ cfe/trunk/unittests/Tooling/ExecutionTest.cpp
@@ -95,8 +95,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
llvm::Error
execute(llvm::ArrayRef<std::pair<std::unique_ptr<FrontendActionFactory>,
ArgumentsAdjuster>>) override {
Index: cfe/trunk/include/clang/Tooling/StandaloneExecution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/StandaloneExecution.h
+++ cfe/trunk/include/clang/Tooling/StandaloneExecution.h
@@ -52,8 +52,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
using ToolExecutor::execute;
llvm::Error
Index: cfe/trunk/include/clang/Tooling/Execution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/Execution.h
+++ cfe/trunk/include/clang/Tooling/Execution.h
@@ -115,13 +115,6 @@
/// Returns the name of a specific executor.
virtual StringRef getExecutorName() const = 0;
- /// Should return true iff executor runs all actions in a single process.
- /// Clients can use this signal to find out if they can collect results
- /// in-memory (e.g. to avoid serialization costs of using ToolResults).
- /// The single-process executors can still run multiple threads, but all
- /// executions are guaranteed to share the same memory.
- virtual bool isSingleProcess() const = 0;
-
/// Executes each action with a corresponding arguments adjuster.
virtual llvm::Error
execute(llvm::ArrayRef<
Index: cfe/trunk/include/clang/Tooling/AllTUsExecution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/AllTUsExecution.h
+++ cfe/trunk/include/clang/Tooling/AllTUsExecution.h
@@ -44,8 +44,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
using ToolExecutor::execute;
llvm::Error
Index: cfe/trunk/unittests/Tooling/ExecutionTest.cpp
===================================================================
--- cfe/trunk/unittests/Tooling/ExecutionTest.cpp
+++ cfe/trunk/unittests/Tooling/ExecutionTest.cpp
@@ -95,8 +95,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
llvm::Error
execute(llvm::ArrayRef<std::pair<std::unique_ptr<FrontendActionFactory>,
ArgumentsAdjuster>>) override {
Index: cfe/trunk/include/clang/Tooling/StandaloneExecution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/StandaloneExecution.h
+++ cfe/trunk/include/clang/Tooling/StandaloneExecution.h
@@ -52,8 +52,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
using ToolExecutor::execute;
llvm::Error
Index: cfe/trunk/include/clang/Tooling/Execution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/Execution.h
+++ cfe/trunk/include/clang/Tooling/Execution.h
@@ -115,13 +115,6 @@
/// Returns the name of a specific executor.
virtual StringRef getExecutorName() const = 0;
- /// Should return true iff executor runs all actions in a single process.
- /// Clients can use this signal to find out if they can collect results
- /// in-memory (e.g. to avoid serialization costs of using ToolResults).
- /// The single-process executors can still run multiple threads, but all
- /// executions are guaranteed to share the same memory.
- virtual bool isSingleProcess() const = 0;
-
/// Executes each action with a corresponding arguments adjuster.
virtual llvm::Error
execute(llvm::ArrayRef<
Index: cfe/trunk/include/clang/Tooling/AllTUsExecution.h
===================================================================
--- cfe/trunk/include/clang/Tooling/AllTUsExecution.h
+++ cfe/trunk/include/clang/Tooling/AllTUsExecution.h
@@ -44,8 +44,6 @@
StringRef getExecutorName() const override { return ExecutorName; }
- bool isSingleProcess() const override { return true; }
-
using ToolExecutor::execute;
llvm::Error
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
