sepavloff marked 2 inline comments as done. sepavloff added a comment. In D65994#1625457 <https://reviews.llvm.org/D65994#1625457>, @rjmccall wrote:
> Since this setting changes IR output, you should write a test that emits IR > for source code and tests that you get the right IR output. This patch is a part of patch chain, it extends FPOptions with new options. In D65997 <https://reviews.llvm.org/D65997> `pragma clang fp` is extended to manipulate these options. Finally D66092 <https://reviews.llvm.org/D66092> modifies code generator so that it emit IR depending on the new options in FPOptions, it makes possible to write IR tests. In D65994#1623088 <https://reviews.llvm.org/D65994#1623088>, @kpn wrote: > In D65994#1622840 <https://reviews.llvm.org/D65994#1622840>, @aaron.ballman > wrote: > > > In general, this seems reasonable, but is missing test code. > > > The IRBuilder does have a strict FP mode setting now. When strict mode is > enabled the (implemented) constrained intrinsics automatically replace the > normal FP instructions. I wonder if that would be right for testing of this > patch? It is just what D66092 <https://reviews.llvm.org/D66092> does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65994/new/ https://reviews.llvm.org/D65994 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
