NoQ added inline comments.
================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:561
+ CmdLineOption<Boolean,
+ "ShowFixIts",
+ "Enable fix-it hints for this checker",
----------------
Charusso wrote:
> `Show` -> `Enable`?
> **recursion**, //n.,// see "recursion"
I think it's valuable when the object and the documentation describe the same
idea in //different// words.
================
Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:308
+//===----------------------------------------------------------------------===//
+// Unsinged analyzer options.
+//===----------------------------------------------------------------------===//
----------------
Charusso wrote:
> `Unsinged` -> `Unsigned`
:D
> **unsinged**, //adj.,// "not popular among singers"
Fxd.
================
Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:103
void enableWerror() { ShouldEmitAsError = true; }
+ void enableFixitsAsRemarks() { FixitsAsRemarks = true; }
----------------
Charusso wrote:
> `FixIt` with capital `i`.
It looks as if people write `FixIt` when they mean "fix-it" as an adjective
(eg., "fix-it hint", "fix-it location") but `Fixit` when they mean "a fixit" as
a noun.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65182/new/
https://reviews.llvm.org/D65182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
