NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Accept as long as we agree on the wording as part of D65575 <https://reviews.llvm.org/D65575>. ================ Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:465 void assert(int b) { - if (!b) // tracking-note{{Assuming 'b' is not equal to 0}} + if (!b) // tracking-note{{Assuming 'b' is not equal to 0, which will be (a part of a) condition}} // tracking-note@-1{{Taking false branch}} ---------------- Do i understand correctly that this test was passing previously, because `expected-note` matches substrings rather than the whole string? If we stick to the current wording, should we slowly switch to `expected-note-re{{{{^}}...{{$}}}}` in order to avoid such situations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65725/new/ https://reviews.llvm.org/D65725 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
