ilya-biryukov added a comment.

Tried the suggested approach and ran into the issue described above.
Either we make the diagnostics less useful ('did you mean foo::bar?' turns into 
'unresolved identifier bar'; without mentioning the correction)  or we even 
stop providing some corrections in addition to that.

On the other hand, I agree that over time we will start emitting too many 
diagnostics at the end of TU if keep the patch as is. That is not a good way.
There should be a better option for emitting the uncorrected diagnostics closer 
to where they are produced, but I don't have a good idea on what it should be 
off the top of my head. Ideas warmly welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64799/new/

https://reviews.llvm.org/D64799



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to