nand marked 10 inline comments as done. nand added a comment. We can add a separate integer type which tracks all the additional information required by `__builtin_constant_p` and compile all integers to it in this context. A later patch added an APInt fallback to the interpreter if an integral cannot be mapped to a type supported by the VM - this mechanism could be used to implement the fallback for contexts which cast pointers to integers.
================ Comment at: clang/lib/AST/ExprVM/Compiler.h:125 + /// Size of the local, in bytes. + unsigned Size; + }; ---------------- jfb wrote: > `ByteSize` since it's the size in bytes :) I've removed the size field since it's not going to be used, but left the structure since it will gain other fields in future patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
