Patch looks good. Please also add a testcase to test/Headers.
On Tue, Feb 9, 2016 at 12:08 PM, Hubert Tong via cfe-commits <cfe-commits@lists.llvm.org> wrote: > I see no immediate issue with this patch, but I am not one of the usual > reviewers for this part of the code base. > > -- HT > > > On Tue, Feb 9, 2016 at 2:56 PM, Jorge Teixeira <j.lopes.teixe...@gmail.com> > wrote: >> >> Thanks Hubert. Somehow I omitted that prefix when typing the macros, >> and I did not noticed it when I was testing because on my arch >> DECIMAL_DIG is defined to be the LDBL version... >> >> Updated patch is attached. >> >> JT >> >> On Tue, Feb 9, 2016 at 1:41 PM, Hubert Tong >> <hubert.reinterpretc...@gmail.com> wrote: >> > There is a __LDBL_DECIMAL_DIG__ predefined macro. __DECIMAL_DIG__ will >> > not >> > always be the same as __LDBL_DECIMAL_DIG__. >> > >> > -- HT >> > >> > On Mon, Feb 8, 2016 at 11:26 PM, Jorge Teixeira via cfe-commits >> > <cfe-commits@lists.llvm.org> wrote: >> >> >> >> Hi, I filed the bug (https://llvm.org/bugs/show_bug.cgi?id=26283) some >> >> time ago and nobody picked it up, so here is a trivial patch exposing >> >> the missing macros, that to the best of my ability were already >> >> present as the internal underscored versions. >> >> >> >> Perhaps a more general bug about C11 floating point (lack of) >> >> conformance should be filed, so that some form of unit test/macro >> >> validation could be worked on, but this patch does scratch my current >> >> itch. >> >> >> >> Successfully tested on x86-64 Xubuntu 14.04 with clang 3.8 from the >> >> ppa, patched with the attached diff. >> >> >> >> First contribution, so feel free to suggest improvements or point to >> >> more detailed step-by-step instructions/guidelines. >> >> >> >> Cheers, >> >> >> >> JT >> >> >> >> _______________________________________________ >> >> cfe-commits mailing list >> >> cfe-commits@lists.llvm.org >> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >> >> > > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
